Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp Coordinate constructors #101

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Revamp Coordinate constructors #101

merged 4 commits into from
Dec 5, 2024

Conversation

dxrcy
Copy link
Contributor

@dxrcy dxrcy commented Oct 29, 2024

  • Add constexpr
  • Remove explicit
  • Use list initialization
  • Disallow omitting y and z arguments (breaking change)

@rozukke
Copy link
Owner

rozukke commented Oct 30, 2024

Looks good, but will have to delay until next "release" due to breaking change 👍

@rozukke rozukke added next-release To be released next time breaking changes are allowed enhancement New feature or request behaviour Incorrect program behaviour labels Oct 30, 2024
@rozukke rozukke merged commit 2f7f223 into rozukke:main Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
behaviour Incorrect program behaviour enhancement New feature or request next-release To be released next time breaking changes are allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxrcy @rozukke